Update topic_cmd.cpp#28
Open
squidlox wants to merge 1 commit into
Open
Conversation
may help mitigate file loading errors
Contributor
|
looks good to me but I'm not a maintainer :( |
Contributor
|
It's kind of a band-aid fix, but it probably works; I made a PR with a completely new function and system of handling opening the file, so you might want to look into that, but then again THAT might not be merged so this is also a good enough solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
may help mitigate file loading errors
Adds a for loop to topic_cmd.cpp that will retry loading the topic string if it is empty.
adds one int variable for max load attempts in the for loop. this is needed to keep the bot from looping infinitely in the case the file is not able to be loaded.
Shouldn't break anything but I'm new so please check extra carefully